Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 404 Not Found page #7634

Merged
merged 2 commits into from
Mar 2, 2024
Merged

Conversation

coderNadir
Copy link
Contributor

@coderNadir coderNadir commented Mar 1, 2024

PR

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Issue => #7632


Before:

Wasn't redirecting when clicking (Take me home) button

image

After:

Redirect automatically to home page (Dashboards) after 3 seconds

Gauzy-improve-404.mp4

@coderNadir coderNadir changed the title Redirect user to home page after 3 sec, style Not Found page Improve 404 Not Found page Mar 1, 2024
Copy link

nx-cloud bot commented Mar 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 864648d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

'PAGE_NOT_FOUND.THE_PAGE_YOU_WERE_LOOKING_FOR_DOESNT_EXIST' | translate
}}
</small>
<p class="btn btn-block btn-hero-primary">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderNadir user may still want to CLICK on that button before it automatically redirects, why you have removed (click) etc???

@coderNadir
Copy link
Contributor Author

@evereq Check this video show how now it's redirecting auto and the user also can redirect himself without waiting for 3 sec to finish!

Gauzy-improve-404-v2.mp4

@evereq evereq merged commit e66b19f into develop Mar 2, 2024
12 of 18 checks passed
@evereq evereq deleted the fix/#7632-improve-not-found-page branch March 2, 2024 14:22
evereq added a commit that referenced this pull request Mar 4, 2024
* refactor: optimized organization team findAll query

* fix: create and update organization team APIs

* fix: memberIds not defined

* fix: removed console

* Update Dockerfile

* #7589 - Deployment to DO Droplets / Other VMs via SSH (#7591)

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* Update docker-compose.api.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* chore: Deploy API to DO App Platform (WIP)

* added docker-compose-api and deploy-do-droplet-demo.yml

* added docker-compose-api and deploy-do-droplet-demo.yml

* chore: Deploy to DO App Platform (WIP)

* added docker-compose-api and deploy-do-droplet-demo.yml

* chore: fix of Deploy to DO App Platform (WIP)

* added docker-compose-api and deploy-do-droplet-demo.yml

* chore: temporary

* chore: fix

* chore: fix

* chore: fix envsubst

* chore: fix

* added docker-compose-api and deploy-do-droplet-demo.yml

* chore: fix

* chore: fix

* added docker-compose-api and deploy-do-droplet-demo.yml

* chore: fix

* added docker-compose-api and deploy-do-droplet-demo.yml

* chore: fix

* chore: by mistake :)

* added docker-compose-api and deploy-do-droplet-demo.yml

* chore: fix

* chore: fix

* chore: switch to smaller instances

* chore: show list of apps

* chore: fix

* chore: fix

* chore: add stage

* chore: fix branches

---------

Co-authored-by: geoffrey1330 <israelgeoffrey13@gmail.com>

* chore: fix

* chore: fix

* chore: fix

* chore: fix

* chore: update deployments to DO App Platform and add to README.md

* fix: #7631 | sticky smart table header

* Improve 404 Not Found page (#7634)

* fix: #7632 | redirect user to home page after 3 sec, style page

* fix: #7632 | add button so user redirect himself instead of waiting to get redirected auto

* [Refactor] Tenant / Role Permission Guard (#7644)

* fix: used direct role permission service instead of join using user

* fix: added role permission module for permission guard

* fix: added role permission module for permission guard

* fix: added role permission module for permission guard

* fix: added role permission module for permission guard

* fix: added role permission module for permission guard

* fix: added role permission module for permission guard

* fix: added role permission module for permission guard

* fix: added role permission module for permission guard

* fix: direct query count for role permission check

* fix: removed tenant module (unnecessary module)

* fix: removed tenant module (unnecessary module)

* fix: removed tenant module (unnecessary module)

* fix: removed tenant module (unnecessary module)

* fix: removed tenant module (unnecessary module)

* fix: removed tenant module (unnecessary module)

* fix: removed tenant module (unnecessary module)

* fix: removed tenant module (unnecessary module)

* fix: updated auth module

* fix: removed tenant module (unnecessary module)

* fix: removed tenant module (unnecessary module)

* fix: removed tenant module (unnecessary module)

* fix: added role permission module for permission guard

* fix: removed tenant module (unnecessary module)

* fix: removed tenant module (unnecessary module)

* fix(deepscan): removed unused import

* chore: increase RAM limits

* chore: log heap size

* feat: add caching to some Middlewares and other improvements

---------

Co-authored-by: RAHUL RATHORE <41804588+rahul-rocket@users.noreply.github.com>
Co-authored-by: Rahul R <rahulrathore576@gmail.com>
Co-authored-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Co-authored-by: CoderNadir <coder.nadir@gmail.com>
Co-authored-by: coderNadir <78637183+coderNadir@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants