-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daily plan tasks #7775
Daily plan tasks #7775
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 751840d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targetsSent with 💌 from NxCloud. |
@GloireMutaliko21 please go to #7775 (comment) and follow "CLA | not signed" button :) |
@GloireMutaliko21 great start man 🚀 , let's continue, I converted for now to Draft PR before you will be ready with all functionality, but it looks like going in right direction! |
packages/core/src/database/migrations/1714063803808-createDailyPlanEntity.ts
Outdated
Show resolved
Hide resolved
@@ -182,12 +182,12 @@ export class TaskService extends TenantAwareCrudService<Task> { | |||
query.setFindOptions({ | |||
...(isNotEmpty(options) && | |||
isNotEmpty(options.where) && { | |||
where: options.where | |||
}), | |||
where: options.where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GloireMutaliko21 Make do not push unnecessary formatting changes please.
packages/core/src/database/migrations/1714189133255-AlterWorkTimePlannedColumnForDailyPlan.ts
Outdated
Show resolved
Hide resolved
...s/core/src/database/migrations/1714185928435-CreateTablesDailyPlanAndTasksUsingManyToMany.ts
Outdated
Show resolved
Hide resolved
packages/core/src/tasks/daily-plan/dto/create-daily-plan.dto.ts
Outdated
Show resolved
Hide resolved
@GloireMutaliko21 also please watch out for DeepScan errors report and fix those (see above in the Checks list) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GloireMutaliko21 We have still we issues in filter daily plans for ADMIN user. I am merging this PR for now. But please work on that filter issues.
PR
Ticket : [ever-co/ever-teams/issues/2391]
Pull request content