Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily plan tasks #7775

Merged
merged 37 commits into from
Apr 30, 2024
Merged

Daily plan tasks #7775

merged 37 commits into from
Apr 30, 2024

Conversation

GloireMutaliko21
Copy link
Member

@GloireMutaliko21 GloireMutaliko21 commented Apr 25, 2024

PR

Ticket : [ever-co/ever-teams/issues/2391]

Pull request content

  • Create a daily plan
  • Get daily plan for a given employee
  • Get my plans
  • Delete a task from a daily plan
  • Delete a plan
  • Update plan

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

nx-cloud bot commented Apr 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 751840d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@evereq
Copy link
Member

evereq commented Apr 25, 2024

@GloireMutaliko21 please go to #7775 (comment) and follow "CLA | not signed" button :)

@evereq evereq marked this pull request as draft April 25, 2024 18:03
@evereq
Copy link
Member

evereq commented Apr 25, 2024

@GloireMutaliko21 great start man 🚀 , let's continue, I converted for now to Draft PR before you will be ready with all functionality, but it looks like going in right direction!

packages/contracts/src/daily-plan.model.ts Outdated Show resolved Hide resolved
packages/core/src/core/entities/internal.ts Outdated Show resolved Hide resolved
packages/core/src/employee/employee.entity.ts Outdated Show resolved Hide resolved
packages/core/src/employee/employee.entity.ts Outdated Show resolved Hide resolved
packages/core/src/employee/employee.entity.ts Outdated Show resolved Hide resolved
@GloireMutaliko21 GloireMutaliko21 marked this pull request as ready for review April 28, 2024 18:54
packages/contracts/src/daily-plan.model.ts Outdated Show resolved Hide resolved
packages/core/src/app.module.ts Outdated Show resolved Hide resolved
@@ -182,12 +182,12 @@ export class TaskService extends TenantAwareCrudService<Task> {
query.setFindOptions({
...(isNotEmpty(options) &&
isNotEmpty(options.where) && {
where: options.where
}),
where: options.where
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GloireMutaliko21 Make do not push unnecessary formatting changes please.

packages/core/src/tasks/daily-plan/daily-plan.module.ts Outdated Show resolved Hide resolved
packages/core/src/tasks/daily-plan/daily-plan.service.ts Outdated Show resolved Hide resolved
packages/core/src/tasks/daily-plan/daily-plan.service.ts Outdated Show resolved Hide resolved
@evereq
Copy link
Member

evereq commented Apr 29, 2024

@GloireMutaliko21 also please watch out for DeepScan errors report and fix those (see above in the Checks list)

Copy link
Collaborator

@rahul-rocket rahul-rocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GloireMutaliko21 We have still we issues in filter daily plans for ADMIN user. I am merging this PR for now. But please work on that filter issues.

@rahul-rocket rahul-rocket merged commit 57edbe3 into develop Apr 30, 2024
13 of 19 checks passed
@rahul-rocket rahul-rocket deleted the feat/daily-plan branch April 30, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants