[Feat] Daily plan | Compare estimated UI Only #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Innocent-Akim
added
WEB
Innocent-Akim
removed
the
Don't Merge
Cedric921
changed the title
Cedric921
reviewed
Jul 20, 2024
| } | ||
|
|
||
|
|
||
| export function ButtonAction({ closeModal, onClick }: { closeModal?: () => void, onClick?: () => void }) { |
There was a problem hiding this comment.
we can remane this component to DailyPlanCompareActionButton
| } | ||
|
|
||
|
|
||
| export function HeadTitle() { |
There was a problem hiding this comment.
We can also rename this component to DailyPlanCompareHeader
| } | ||
|
|
||
|
|
||
| export function InputTime({ onChange }: { onChange?: (_: any) => void }) { |
There was a problem hiding this comment.
We can also rename to DailyPlanWorkTimeInput
| </Modal> | ||
| ) | ||
| } | ||
| export function CardDailyPlan({ task, profile }: { task?: ITeamTask, profile: any }) { |
There was a problem hiding this comment.
let's rename to DailyPlanTask
|
@Cedric921 we should wait till @Innocent-Akim fix all those things from your comments? If so, maybe convert it to Draft for now? |
|
i'll change that in Next PR @Cedric921 @evereq |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature] 'Daily Plan' compare Estimated tasks time and Planned work hours #2614