Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Upgrade packages to avoid security vulnerability #7

Merged
merged 1 commit into from
Aug 29, 2019
Merged

fix: Upgrade packages to avoid security vulnerability #7

merged 1 commit into from
Aug 29, 2019

Conversation

ermand
Copy link
Contributor

@ermand ermand commented Aug 28, 2019

Description

Upgrade packages to avoid security vulnerabilities such as:

Known critical severity security vulnerability detected in eslint-utils >= 1.2.0, < 1.4.1 defined in yarn.lock.
--
yarn.lock update suggested: eslint-utils ~> 1.4.1.

IslamWahid
IslamWahid suggested changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@IslamWahid IslamWahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing

@ermand
Copy link
Contributor Author

ermand commented Aug 28, 2019

tests are failing

Looks like the tests are failing even in master :(

@IslamWahid IslamWahid mentioned this pull request Aug 28, 2019
Merged
@IslamWahid
Copy link
Contributor

IslamWahid commented Aug 28, 2019 •
edited
Loading

@ermand here's the fix them #8

@ermand ermand merged commit e184963 into master Aug 29, 2019
@ermand ermand deleted the fix/upgrade_packages branch August 29, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IslamWahid IslamWahid IslamWahid requested changes

@SaraKola SaraKola Awaiting requested review from SaraKola

@madhav-hugar madhav-hugar Awaiting requested review from madhav-hugar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ermand @IslamWahid