Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix failing tests after jest upgrade #8

Merged
merged 2 commits into from
Aug 29, 2019

Conversation

IslamWahid
Copy link
Contributor

@IslamWahid IslamWahid commented Aug 28, 2019

Short description of what this resolves:

fix failing tests after jest upgrade

Changes proposed in this pull request:

  • use await for the promises before expecting on them
  • stop returning from describe callback

Fixes:

  • failing tests after jest upgrade
  • jest warning:A "describe" callback must not return a value. Returning a value from "describe" will fail the test in a future version of Jest.

dependent On:
#7

CI
Screen Shot 2019-08-28 at 17 23 55

ermand and others added 2 commits August 28, 2019 15:25
- fix failing tests
- handle jest warning:
`A "describe" callback must not return a value.
        Returning a value from "describe" will fail the test in a future version of Jest.`
Copy link
Contributor

@ermand ermand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :) Thanks 🙏

@ermand ermand merged commit 405441a into master Aug 29, 2019
@ermand ermand deleted the test/fix-failing-tests-after-jest-upgrade branch August 29, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants