Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapter for phpredis/phpredis extension #3

Merged
merged 1 commit into from
Oct 24, 2015
Merged

Adapter for phpredis/phpredis extension #3

merged 1 commit into from
Oct 24, 2015

Conversation

korotovsky
Copy link
Contributor 

korotovsky@korotovsky:~/Development/redlock$ php vendor/bin/phpunit tests/
PHPUnit 4.6.4 by Sebastian Bergmann and contributors.

Configuration read from /home/korotovsky/Development/redlock/phpunit.xml.dist

........................................................

Time: 43.87 seconds, Memory: 7.75Mb

OK (56 tests, 323 assertions)
korotovsky@korotovsky:~/Development/redlock$

It also fixes #2

@korotovsky korotovsky changed the title Added PhpredisAdapter for https://github.com/phpredis/phpredis Adapter for phpredis/phpredis extension Oct 6, 2015
@korotovsky korotovsky mentioned this pull request Oct 6, 2015
Closed
michcald
michcald reviewed Oct 7, 2015
View reviewed changes
src/Adapter/PhpredisAdapter.php
use Everlution\Redlock\Exception\Adapter\InvalidTtlException;
use RedisException;

class PhpredisAdapter implements AdapterInterface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have preferred it being named PhpRedisAdapter

@korotovsky
Copy link
Contributor Author

@michcald ping

@michcald
Copy link
Contributor

Thanks for this, merging now.

michcald added a commit that referenced this pull request Oct 24, 2015
@michcald
Merge pull request #3 from korotovsky/phpredis
276ce20 
Adapter for phpredis/phpredis extension
@michcald michcald merged commit 276ce20 into everlution:master Oct 24, 2015
@korotovsky
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"predis/predis" package should be in "suggest" section not in "required"
2 participants
@korotovsky @michcald