Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check device existence #3

Merged
merged 2 commits into from
Oct 25, 2018

Conversation

dtaniwaki
Copy link
Contributor

@dtaniwaki dtaniwaki commented Oct 24, 2018

I found a problem that a pod w/ host device resources can get deployed to a node thanks to this device plugin but failed to use it if the node actually doesn't have the device. I made it unhealthy. We still need to dynamically change the health by device existence changes.

@everpeace
Copy link
Owner

How about returning empty device list instead of unhealthy devices??

@dtaniwaki
Copy link
Contributor Author

I made devices Unhealthy because it might come up a while later. However, to we handle the health state properly, we still need periodical health check which is not included in this PR and the implementation is not completed. I'll make the change in this PR as well.

@everpeace
Copy link
Owner

lgtm. thanks!

@everpeace everpeace merged commit 7ca463c into everpeace:master Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants