Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some tests for koa-cors #10

Merged
merged 4 commits into from
May 23, 2014
Merged

added some tests for koa-cors #10

merged 4 commits into from
May 23, 2014

Conversation

bodokaiser
Copy link
Contributor

This pull request adds support for testing default settings of loa-cors also it supports the following options:

  • origin to true and false
  • expose as string and as array
  • `maxAge´ as integer

The others are missing but I guess they work fine.

@evert0n
Copy link
Owner

evert0n commented May 23, 2014

@bodokaiser Thank you very much to send this, awesome work

evert0n added a commit that referenced this pull request May 23, 2014
added some tests for koa-cors
@evert0n evert0n merged commit ffc2f42 into evert0n:master May 23, 2014
@bodokaiser
Copy link
Contributor Author

@evert0n just for the future you might want to use supertest for testing http responses.

I just figured out today how to use them with loa (https://github.com/bodokaiser/koa-lessie/blob/master/test/index.js)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants