This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Allow management of the Zookeeper service. #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new attribute node[:zookeeper][:service_style] which is examined during a new service recipe. Depending on its value, either a Runit service or Exhibitor management is provided.
|
@jakedavis this is great! Nice to finally see how this cookbook & the Exhibitor one can fit together. Thanks for all the hard work on this stuff. |
|
Thanks! It has been a bit of a journey but I think it's improving :) Will merge and bump. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first pass towards #86, this PR adds the ability to examine a new
node[:zookeeper][:service_style]attribute and either create a Runit service, or allow Exhibitor to manage Zookeeper. It doesn't do anything special for Exhibitor; that is a decision to revisit later (perhaps a suggests in metadata for Exhibitor). For now, it'll log a different message, just to indicate this is a "valid" value.