Address some feedback from Jeremy

* Decrease likelihood of cache collisions * Avoid file:// urls (and therefore the need to escape)
everydayhero · Apr 19, 2013 · 3064886 · 3064886
1 parent 394d8aa
commit 3064886
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/bin/ruby-build b/bin/ruby-build
@@ -294,15 +294,15 @@ fetch_git() {
   if type git &>/dev/null; then
     if [ -n "$RUBY_BUILD_CACHE_PATH" ]; then
       pushd "$RUBY_BUILD_CACHE_PATH" >&4
-      local clone_name=$(echo $git_url | sed "s/[^a-z0-9.]/_/g; s/__*/_/g")
+      local clone_name=$(echo $git_url | sed "s/[^A-Za-z0-9.-]/_/g; s/__*/_/g")
       if [ -e "${clone_name}" ]; then
         { cd "${clone_name}"
           git fetch --force "$git_url" "+${git_ref}:${git_ref}" 
         } >&4 2>&1
       else
         git clone --bare --branch "$git_ref" "$git_url" "${clone_name}" >&4 2>&1
       fi
-      git_url="file://$RUBY_BUILD_CACHE_PATH/${clone_name}"
+      git_url="$RUBY_BUILD_CACHE_PATH/${clone_name}"
       popd >&4
     fi