Add Wikidata id as id where available #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to look up Wikidata IDs for each of the links on the page.
tmtmtmtm
force-pushed
the
wikidata-decorator
branch
from
eda729c
to
72dec66
Compare
For every link to a suitable page in the same wiki (ie not a Special page, or one in a different namespace) look up its Wikidata ID, and attach that as an attribute of the link, suitable for the scraper to extract again. wikidata-fetcher neatly encapsulates that lookup for us already, including doing them in suitably sized batches.
If we can finda a wikidata ID for the linked page, set it as the ID. This will protect us slightly from wikipedia-level renamings.
tmtmtmtm
force-pushed
the
wikidata-decorator
branch
from
72dec66
to
7fceae7
Compare
chrismytton
requested changes
Feb 16, 2017
| @@ -21,3 +21,5 @@ gem 'scraperwiki', github: 'openaustralia/scraperwiki-ruby', | |||
| gem 'table_unspanner', github: 'everypolitician/table_unspanner' | |||
| gem 'vcr' | |||
| gem 'webmock' | |||
| gem 'wikidata-fetcher', '>= 0.19.1', github: 'everypolitician/wikidata-fetcher' | |||
| gem 'wikisnakker', github: 'everypolitician/wikisnakker' | |||
There was a problem hiding this comment.
It doesn't look like wikisnakker is being used at all here, is it actually needed?
| @@ -21,3 +21,5 @@ gem 'scraperwiki', github: 'openaustralia/scraperwiki-ruby', | |||
| gem 'table_unspanner', github: 'everypolitician/table_unspanner' | |||
| gem 'vcr' | |||
| gem 'webmock' | |||
| gem 'wikidata-fetcher', '>= 0.19.1', github: 'everypolitician/wikidata-fetcher' | |||
There was a problem hiding this comment.
From what I can tell we're only using the wikidata-client dependency from wikidata-fetcher, so perhaps it would be better to have a dependency on that instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we can finda a wikidata ID for the linked page, set it as the ID. This
will protect us slightly from wikipedia-level renamings.