Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release files directly after reading. #160

Merged
merged 3 commits into from
May 29, 2024
Merged

Release files directly after reading. #160

merged 3 commits into from
May 29, 2024

Conversation

evetion
Copy link
Owner

@evetion evetion commented May 26, 2024

Fixes #159

@hustf
Copy link

hustf commented May 26, 2024

Running this PR locally shows the same problems with libgeotiff.dll. Pinning ArchGDAL to v0.10.3 does not help.

This should probably be its own issue, because the installation problem now also occurs on the latest release of GeoArrays. The offending package is not obvious. So I tried updating my previously working environment (BitmapMaps) which had a working current-release GeoArrays, this also errored. The offending library is probably one of these:

(BitmapMaps) pkg> update
    ...
   Installed FreeType2_jll ───── v2.13.2+0
   Installed VectorizationBase ─ v0.21.68
  Downloaded artifact: FreeType2
  No Changes to `C:\Users\f\.julia\dev\BitmapMaps\Project.toml`
    Updating `C:\Users\f\.julia\dev\BitmapMaps\Manifest.toml`
  [c9ce4bd3] ↑ ArchGDAL v0.10.3 ⇒ v0.10.4
  [20f20a25] ↑ MakieCore v0.8.0 ⇒ v0.8.2
  [3d5dd08c] ↑ VectorizationBase v0.21.67 ⇒ v0.21.68
  [d7e528f0] ↑ FreeType2_jll v2.13.1+0 ⇒ v2.13.2+0
  [d604d12d] ↑ GEOS_jll v3.12.0+0 ⇒ v3.12.1+0
  [58948b4f] ↑ PROJ_jll v901.300.0+1 ⇒ v901.400.0+0
  [02c8fc9c] ↑ XML2_jll v2.12.6+0 ⇒ v2.12.7+0

@evetion
Copy link
Owner Author

evetion commented May 26, 2024

Sorry, the errors stem from a faulty release upstream, see yeesian/ArchGDAL.jl#427. Workaround is to run add PROJ_jll@901.300 GDAL_jll@301.900.

@hustf
Copy link

hustf commented May 27, 2024

That fixes the install. There's a failed test (roundoff related?), but interestingly:

Bandnames: Error During Test at C:\Users\f\.julia\dev\GeoArrays\test\test_io.jl:112
  Got exception outside of a @test
  IOError: unlink("C:\\Users\\f\\AppData\\Local\\Temp\\test_bandnames.tif"): resource busy or locked (EBUSY)

@evetion
Copy link
Owner Author

evetion commented May 28, 2024

That fixes the install. There's a failed test (roundoff related?), but interestingly:

That was due to the COG driver, at writing it launches an async process to write the overviews to the file, locking it. I've sprinkled earlier destroys throughout the codebase, hopefully you can run your code without locking files.

Can you post/make a new issue about the failed roundoff related test? Rounding numbers is always subtle, but all CI platforms are green, so I also wonder about your OS/platform.

@hustf hustf mentioned this pull request May 29, 2024
@evetion evetion merged commit 6c9cfba into master May 29, 2024
7 checks passed
@evetion evetion deleted the feat/release-file branch May 29, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.tif files not released after reading
2 participants