Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Y Axis labels being truncated on horizontal bar charts #1210

Merged
merged 15 commits into from Oct 2, 2023

Conversation

ItsMeBrianD
Copy link
Member

Description

image
Resolves #1203

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2023

🦋 Changeset detected

Latest commit: cc11af8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@evidence-dev/component-utilities Patch
@evidence-dev/core-components Patch
@evidence-dev/evidence Patch
@evidence-dev/components Patch
evidence-test-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit cc11af8
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/651b4c225d800d000834bedb
😎 Deploy Preview https://deploy-preview-1210--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evidence-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 11:04pm

@mcrascal
Copy link
Member

Any sense why this one isn't showing all axis labels?

@ItsMeBrianD
Copy link
Member Author

Any sense why this one isn't showing all axis labels?

Not sure; I'll take a look

@mcrascal
Copy link
Member

LGTM -- would be good to get @hughess eyes on

Copy link
Member

@hughess hughess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ItsMeBrianD ItsMeBrianD added the ready-to-merge PRs that are approved and have all checks passing label Sep 29, 2023
@mcrascal mcrascal merged commit 5945778 into main Oct 2, 2023
18 checks passed
@mcrascal mcrascal deleted the fix/1203/y-axis-label-trunc branch October 2, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge PRs that are approved and have all checks passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Y axis labels getting truncated or missing in horizontal bar chart
3 participants