Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: note that Snowflake columns will be lowercase #1272

Merged
merged 1 commit into from Oct 16, 2023
Merged

Docs: note that Snowflake columns will be lowercase #1272

merged 1 commit into from Oct 16, 2023

Conversation

DArtagan
Copy link
Contributor

@DArtagan DArtagan commented Oct 16, 2023

Description

Documentation update: in the Snowflake section of Data Sources, add a note that all column names will be converted to lowercase in Evidence. This is significant because Snowflake has the (weird) convention of all table and column names being being uppercase.

It looks like this was design choice made when the Snowflake connector was written, with a comment saying that an issue should be opened to consider this further:
https://github.com/evidence-dev/evidence/blob/cafd4b1f6002a25873949c6c1b62cb72cc4eacd7/packages/snowflake/index.cjs#L158C5-L158C5

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

⚠️ No Changeset found

Latest commit: 9a4f3cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evidence-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 6:01pm

@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit 9a4f3cc
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/652d7a2c6312920008b386a8
😎 Deploy Preview https://deploy-preview-1272--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DArtagan
Copy link
Contributor Author

I imagine you folks don't want a changeset added for a documentation update? Otherwise happy to do so.

@archiewood
Copy link
Member

TY - LGTM

@archiewood archiewood merged commit 2eeeb86 into evidence-dev:main Oct 16, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants