Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug navigating away from settings page #1695

Merged
merged 3 commits into from Mar 6, 2024
Merged

Fix bug navigating away from settings page #1695

merged 3 commits into from Mar 6, 2024

Conversation

hughess
Copy link
Member

@hughess hughess commented Mar 6, 2024

Description

There was a bug that would crash the page if you opened a connection's settings in the Settings page, then attempted to navigate back to a normal page.

This was cause by svelte's animation attempting to close the connection settings pane before navigating.

This PR adds |local to the animation, which solves the issue.

Also adds a border to the db settings panel

Before

CleanShot 2024-03-06 at 15 58 10

After

CleanShot 2024-03-06 at 15 59 23

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset

Copy link

changeset-bot bot commented Mar 6, 2024

🦋 Changeset detected

Latest commit: 3717951

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@evidence-dev/core-components Patch
@evidence-dev/evidence Patch
@evidence-dev/components Patch
evidence-test-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 10:09pm

Copy link

netlify bot commented Mar 6, 2024

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit 3717951
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/65e8e99390b35c0008de33da
😎 Deploy Preview https://deploy-preview-1695--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hughess
Copy link
Member Author

hughess commented Mar 6, 2024

@csjh could this be the same thing that's happening with the sql console? #1640

@csjh
Copy link
Member

csjh commented Mar 6, 2024

Definitely

@hughess
Copy link
Member Author

hughess commented Mar 6, 2024

@csjh ok sweet I'll add that in here too

@hughess
Copy link
Member Author

hughess commented Mar 6, 2024

I'm also getting an error by default when navigating to the sql console - happens in a fresh install as well:
CleanShot 2024-03-06 at 16 41 36@2x

@hughess hughess merged commit f45222c into next Mar 6, 2024
11 checks passed
@hughess hughess deleted the setting-nav-bug branch March 6, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants