New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug navigating away from settings page #1695
Conversation
🦋 Changeset detectedLatest commit: 3717951 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for evidence-development-workspace ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Definitely |
@csjh ok sweet I'll add that in here too |
Description
There was a bug that would crash the page if you opened a connection's settings in the Settings page, then attempted to navigate back to a normal page.
This was cause by svelte's animation attempting to close the connection settings pane before navigating.
This PR adds
|local
to the animation, which solves the issue.Also adds a border to the db settings panel
Before
After
Checklist