Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slugified ToC Links #1760

Closed
wants to merge 23 commits into from
Closed

Slugified ToC Links #1760

wants to merge 23 commits into from

Conversation

archiewood
Copy link
Member

@archiewood archiewood commented Mar 19, 2024

Description

This redesigns the toc with slugified links rather than using ascending numbers.

Issues

This does not solve a more general problem with the TOC that you cannot navigate to anchor links from off page becuase the ids are generated after the page loads

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable
  • I have added to the VS Code extension where applicable

Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: ed09018

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@evidence-dev/core-components Patch
@evidence-dev/evidence Patch
my-evidence-project Patch
@evidence-dev/components Patch
evidence-test-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ❌ Failed (Inspect) Mar 20, 2024 7:48pm

Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for evidence-docs failed. Why did it fail? →

Name Link
🔨 Latest commit ed09018
🔍 Latest deploy log https://app.netlify.com/sites/evidence-docs/deploys/65fb3c7144e71200086bdf98

@archiewood
Copy link
Member Author

closing in favour of #1806

@archiewood archiewood closed this Mar 28, 2024
@archiewood archiewood deleted the toc branch April 6, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants