Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown multiselect Select all option and DateRange month/year selectors #1798

Merged
merged 11 commits into from Mar 27, 2024

Conversation

csjh
Copy link
Member

@csjh csjh commented Mar 26, 2024

Description

Fixes #1776, #1777

Select all option:
image

Old DateRange:
image

New DateRange:
image

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset

Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: c254329

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@evidence-dev/core-components Minor
@evidence-dev/evidence Major
@evidence-dev/components Patch
evidence-test-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 2:56pm

Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit c254329
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/6604337f9af4e1000794f936
😎 Deploy Preview https://deploy-preview-1798--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@csjh csjh linked an issue Mar 26, 2024 that may be closed by this pull request
@mcrascal
Copy link
Member

mcrascal commented Mar 26, 2024

This is really nice.

Date Range:

  1. The button treatment on the two dropdowns is too heavy w/ the shadows in an existing popover - try the "ghost" variant?
  2. You get visual shift in the calendar popover when you toggle to months of different lengths.
  3. Font size too big relative to the next / pervious icons.

Select all:

  1. This is great. Instead of removing the "clear selection" button when a selection is made, can we just disable it? It's jumpy to have it disappear.

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for evidence-test-env failed. Why did it fail? →

Name Link
🔨 Latest commit c254329
🔍 Latest deploy log https://app.netlify.com/sites/evidence-test-env/deploys/6604337f34f98a000850f84b

@csjh csjh merged commit cb7b45a into next Mar 27, 2024
11 checks passed
@csjh csjh deleted the multiselect-and-date-range-feats branch March 27, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Select All" option for multiselect filters Easier date range selection
3 participants