Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source sql ending in a line comment need final newline #1819

Merged
merged 2 commits into from Apr 10, 2024

Conversation

smilingthax
Copy link

Description

See #1735

Checklist

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 9:52pm

Copy link

changeset-bot bot commented Mar 29, 2024

🦋 Changeset detected

Latest commit: 1da26c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@evidence-dev/db-commons Patch
@evidence-dev/bigquery Patch
@evidence-dev/csv Patch
@evidence-dev/databricks Patch
@evidence-dev/duckdb Patch
@evidence-dev/mssql Patch
@evidence-dev/mysql Patch
@evidence-dev/postgres Patch
@evidence-dev/redshift Patch
@evidence-dev/snowflake Patch
@evidence-dev/sqlite Patch
@evidence-dev/trino Patch
@evidence-dev/db-orchestrator Patch
@evidence-dev/plugin-connector Patch
@evidence-dev/components Patch
evidence-test-environment Patch
@evidence-dev/evidence Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit 1da26c4
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/6615b85cf147a00009773235
😎 Deploy Preview https://deploy-preview-1819--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@archiewood
Copy link
Member

archiewood commented Apr 2, 2024

I believe these tests are failing because forks do not have access to the secrets we need to run e.g. postgres tests

I think this is due to the recent change in test suite that moved from pull_request_target to pull_request

Copy link
Member

@csjh csjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@csjh csjh merged commit 1cbb7a1 into evidence-dev:next Apr 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants