New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix delta null/zero handling and adjust neutral symbol #1825
Conversation
🦋 Changeset detectedLatest commit: 63dc7ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for evidence-development-workspace ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Also could: make it bold - Use a thicker dash: e.g. U+2796 |
Added fix for null and 0 values which were erroring out in the Delta component. 0 values will appear as 0 (or however the user chooses to format them) and nulls will appear as There's likely a better way to handle nulls (N/A, null symbol, dashes of various types), and it might need to be configurable depending on the situation. Leaving it for now, so we can tackle it in the same way across the product. |
Description
Changes delta neutral symbol from en dash to em dash when
symbolPosition=left
This helps with BigValue values where positive values could be confused for negative values.
A better long-term solution is needed for this, but putting this in as a short term fix.
Before
After
Checklist