Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delta null/zero handling and adjust neutral symbol #1825

Merged
merged 3 commits into from Mar 30, 2024
Merged

Conversation

hughess
Copy link
Member

@hughess hughess commented Mar 29, 2024

Description

Changes delta neutral symbol from en dash to em dash when symbolPosition=left

This helps with BigValue values where positive values could be confused for negative values.

A better long-term solution is needed for this, but putting this in as a short term fix.

Before

CleanShot 2024-03-29 at 14 12 56@2x

After

CleanShot 2024-03-29 at 14 16 41@2x

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset

Copy link

changeset-bot bot commented Mar 29, 2024

🦋 Changeset detected

Latest commit: 63dc7ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@evidence-dev/core-components Patch
@evidence-dev/evidence Patch
@evidence-dev/components Patch
evidence-test-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2024 7:16pm

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit 63dc7ef
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/66086502b8ba710008533185
😎 Deploy Preview https://deploy-preview-1825--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@archiewood
Copy link
Member

archiewood commented Mar 29, 2024

Also could: make it bold -

Use a thicker dash: e.g. U+2796

@hughess
Copy link
Member Author

hughess commented Mar 30, 2024

Added fix for null and 0 values which were erroring out in the Delta component.

0 values will appear as 0 (or however the user chooses to format them) and nulls will appear as - to maintain consistency with null treatment elsewhere.

There's likely a better way to handle nulls (N/A, null symbol, dashes of various types), and it might need to be configurable depending on the situation. Leaving it for now, so we can tackle it in the same way across the product.

@hughess hughess merged commit c3a2007 into next Mar 30, 2024
11 checks passed
@hughess hughess deleted the neutral-symbol branch March 30, 2024 19:23
@hughess hughess changed the title Adjust delta neutral symbol Fix delta null/zero handling and adjust neutral symbol Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants