Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header link sizes #1899

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Fix header link sizes #1899

merged 5 commits into from
Apr 16, 2024

Conversation

archiewood
Copy link
Member

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable
  • I have added to the VS Code extension where applicable

Copy link

changeset-bot bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: 779ba49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@evidence-dev/core-components Patch
@evidence-dev/evidence Patch
my-evidence-project Patch
@evidence-dev/components Patch
evidence-test-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for next-docs-evidence ready!

Name Link
🔨 Latest commit 779ba49
🔍 Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/661ee438193ef30008bc0a10
😎 Deploy Preview https://deploy-preview-1899--next-docs-evidence.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit 779ba49
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/661ee438de91c100080cbdb6
😎 Deploy Preview https://deploy-preview-1899--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@archiewood
Copy link
Member Author

Fixes #1896

A better solution might be to always inherit sizing for links

@archiewood archiewood changed the title Fix-header-link-sizes Fix header link sizes Apr 16, 2024
@mcrascal
Copy link
Member

LGTM -- only thing is this edge cases table looks broken enough right now that it'll be hard to know if there's a regression.

@archiewood archiewood merged commit 3091784 into next Apr 16, 2024
9 checks passed
@archiewood archiewood deleted the fix-header-link-sizes branch April 16, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants