Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update deprecated data.query syntax used for stacked charts in example project #1930

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

AyushAgrawal-A2
Copy link
Contributor

Description

Changes:

  • In example-poject, /charts/stacked-charts/ , sql queries were not working due to deprecated data={date.query} syntax. Updated to data={query}

closes #1394

unable to reproduce issue#1394, truncated date string are working when used as x-axis in stacked bar chart

image

query used:

```sql needful_things
select
    substr(order_datetime,1,7) as date,
    category as category,
    sum(sales) as sales_usd0
from needful_things.orders
group by 1, 2
```
<BarChart data={needful_things} x=date y=sales_usd0 series=category type=stacked100/>

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable
  • I have added to the VS Code extension where applicable

Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: 1efc3f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@evidence-dev/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for next-docs-evidence ready!

Name Link
🔨 Latest commit 1efc3f8
🔍 Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/6626d6988d2cd400081dfd4f
😎 Deploy Preview https://deploy-preview-1930--next-docs-evidence.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit 1efc3f8
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/6626d698740bdb00079971a2
😎 Deploy Preview https://deploy-preview-1930--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hughess hughess self-requested a review April 25, 2024 01:33
@hughess hughess closed this Apr 25, 2024
@hughess hughess reopened this Apr 25, 2024
@hughess hughess merged commit 80fc997 into evidence-dev:next Apr 25, 2024
13 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/1394 branch April 25, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stacked bar charts stop working with truncated dates as strings
2 participants