Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AAD authentication in MSSQL connector #1953

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

mycaule
Copy link

@mycaule mycaule commented May 1, 2024

Description

I needed to use this block to be able to login with Active Directory. This is useful if the database uses a passwordless strategy.

authentication: {
    type: "azure-active-directory-default"
  }

Check also timothyhoward/evidence-connector-mssql#1

Screenshots

Screenshot 2024-05-01 at 14 08 17 Screenshot 2024-05-01 at 14 08 30

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable

Copy link

changeset-bot bot commented May 1, 2024

🦋 Changeset detected

Latest commit: 636692f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@evidence-dev/mssql Minor
@evidence-dev/db-orchestrator Patch
@evidence-dev/components Patch
@evidence-dev/evidence Patch
my-evidence-project Patch
evidence-test-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented May 1, 2024

Deploy Preview for docs-evidence ready!

Name Link
🔨 Latest commit 3d68c3a
🔍 Latest deploy log https://app.netlify.com/sites/docs-evidence/deploys/663240ffd8ef6100084ca54b
😎 Deploy Preview https://deploy-preview-1953--docs-evidence.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 1, 2024

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit 636692f
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/6633d512b105d00009f828d9
😎 Deploy Preview https://deploy-preview-1953--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@archiewood archiewood changed the base branch from main to next May 1, 2024 15:22
@archiewood archiewood closed this May 1, 2024
@archiewood archiewood reopened this May 1, 2024
@archiewood
Copy link
Member

archiewood commented May 1, 2024

@mycaule Thanks for this PR

I feel like SQL login is probably not the right name for the username/pw auth flow?

perhaps Username / Password is more descriptive?

@mycaule
Copy link
Author

mycaule commented May 1, 2024

@mycaule Thanks for this PR

I feel like SQL login is probably not the right name for the username/pw auth flow?

perhaps Username / Password is more descriptive?

I used this because it is the vocabulary used by Microsoft, SQL authentication refer to user/pass created in SQL Server
As opposed to the username/password in Active Directory of your organization.

You can check this screenshot

https://learn.microsoft.com/en-us/azure-data-studio/connect#new-installation-of-azure-data-studio-140-and-higher

Copy link

netlify bot commented May 2, 2024

Deploy Preview for next-docs-evidence ready!

Name Link
🔨 Latest commit 636692f
🔍 Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/6633d5120fe5740009757b8e
😎 Deploy Preview https://deploy-preview-1953--next-docs-evidence.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mycaule
Copy link
Author

mycaule commented May 2, 2024

Also added the authentication types @timothyhoward has supported in his plugin.

@hughess hughess closed this May 2, 2024
@hughess hughess reopened this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants