New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension + Doc changes for referencing queries without having to reference the data
object
#307
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Love how much cleaner all this code is, will test it in the tutorial repo. Edit: this is so epic, so much easier to write and manage. Kudos |
Yes all the core functionality works well in the tutorial project, components, loops, {#each} etc - when you merge this I will merge an update there also. |
Thanks for testing it out @archiewood ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! There were a few more references to the data object buried in the component prop tables, so I added a commit to remove those as well.
I just remembered that we should also change the snippets in the VS Code extension to remove “data.” Does that make sense to do in here or should I open a new PR for that? Great job on this syntax change - it’s fantastic, I’m so excited for this. |
|
…y in data attributes
data
object
Took a quick look at how the docs would need to change to reflect that queries can be referenced directly. It was mostly a search and replace so I just opened a PR (with the exception of sql-queries.md). Opening this for feedback.