Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension + Doc changes for referencing queries without having to reference the data object #307

Merged
merged 4 commits into from Jun 10, 2022

Conversation

ud3sh
Copy link
Member

@ud3sh ud3sh commented Jun 8, 2022

Took a quick look at how the docs would need to change to reflect that queries can be referenced directly. It was mostly a search and replace so I just opened a PR (with the exception of sql-queries.md). Opening this for feedback.

@ud3sh ud3sh requested review from hughess and archiewood June 8, 2022 23:59
@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2022

⚠️ No Changeset found

Latest commit: 006ddca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
evidence-docs ✅ Ready (Inspect) Visit Preview Jun 10, 2022 at 5:12PM (UTC)

@archiewood
Copy link
Member

archiewood commented Jun 9, 2022

Love how much cleaner all this code is, will test it in the tutorial repo.

Edit: this is so epic, so much easier to write and manage. Kudos

@archiewood
Copy link
Member

archiewood commented Jun 9, 2022

Yes all the core functionality works well in the tutorial project, components, loops, {#each} etc - when you merge this I will merge an update there also.

@ud3sh
Copy link
Member Author

ud3sh commented Jun 9, 2022

Yes all the core functionality works well in the tutorial project, components, loops, {#each} etc - when you merge this I will merge an update there also.

Thanks for testing it out @archiewood !

Copy link
Member

@hughess hughess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! There were a few more references to the data object buried in the component prop tables, so I added a commit to remove those as well.

@hughess
Copy link
Member

hughess commented Jun 10, 2022

I just remembered that we should also change the snippets in the VS Code extension to remove “data.”

Does that make sense to do in here or should I open a new PR for that?

Great job on this syntax change - it’s fantastic, I’m so excited for this.

@ud3sh
Copy link
Member Author

ud3sh commented Jun 10, 2022

I just remembered that we should also change the snippets in the VS Code extension to remove “data.”

Does that make sense to do in here or should I open a new PR for that?

Great job on this syntax change - it’s fantastic, I’m so excited for this.
@hughess Good callout. If this is it, we can do it under the same PR
https://github.com/evidence-dev/evidence/blob/ce3fcddc47a380d6dafb4a692b05d276db4ead7a/packages/evidence-vscode/snippets/emd.code-snippets

@ud3sh ud3sh changed the title Feedback needed: Doc changes for reflect queries can be references by name Extension + Doc changes for referencing queries without having to reference the data object Jun 10, 2022
@ud3sh ud3sh merged commit 398a84e into main Jun 10, 2022
@ud3sh ud3sh deleted the issue-124-docs branch June 10, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants