Hot Fix (#680, #682, #681)

[Winterhart]

Description

• Attempt to fix Show/Hide issue (Show/hide queries not working after update to latest Evidence version #680)
• Fix build:strict (build:strict command broken in latest version of Evidence #682)
• Fix the Query reactivity (SQL query reactivity affected in most recent version of Evidence #681)
• Fix Param. page (Parameterized pages not loading data in v14 #691)

Demo QueryToast

Demo Reactivity

How I am testing on template

(clone both repo next to reach other in a folder)

In evidence

git checkout 680-fix-showhide-queries
pnpm install
cp ~/<YOUR_PATH>/evidence.settings.json ./sites/example-project/
pnpm run build:dev-workspace && pnpm run postinstall

In template repo

npm install
cp -r ../evidence/packages/evidence node_modules/@evidence-dev
cp -r ../evidence/packages/components node_modules/@evidence-dev
cp -r ../evidence/packages/db-orchestrator ./node_modules/@evidence-dev
cp -r ../evidence/node_modules/@sveltejs ./node_modules
cp -r ../evidence/packages/preprocess node_modules/@evidence-dev 

npm run dev

Checklist

• For UI or styling changes, I have added a screenshot or gif showing before & after
• I have added a changeset

[changeset-bot]

🦋 Changeset detected

Latest commit: cfc9781

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@evidence-dev/evidence	Major
@evidence-dev/preprocess	Minor
@evidence-dev/components	Minor
evidence-test-environment	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
evidence-development-workspace	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 14, 2023 at 10:42PM (UTC)
evidence-docs	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 14, 2023 at 10:42PM (UTC)

[mcrascal]

@Winterhart looking good.

A couple items in my first spin through:

1. In dev mode, the navigation state hangs occasionally: the progress bar runs across the screen, you see the queries executing in the console, but it never concludes the nav. I am seeing this on nav to pages that have all cached queries, or no queries at all (e.g. text/markdown). Suspicion is this is related to the refactor of the query status.
2. In Safari, I think due to the upgrade to SK 1.6.0 I am seeing complaints about the available favicons Error: Not found: /apple-touch-icon.png

[archiewood]

Yeah nice progress!

• build:strict working
• show/hide working

Issues:

Query reactivity:

• Not working reliably for me - see gif. Sometimes it does, but sometimes it does not and I'm not clear exactly why. It seems to think the query has not changed and is reporting that it's loading from cache

Other

• When in monorepo pnpm run dev and navigating to the settings menu, for a while, selecting the BiqQuery connector does nothing (ie didnt cause the form to drop down).
• I'm getting unstyled content for about a second before the page loads (this may be unrelated)
  

[archiewood]

This PR also appears to fix #691

[Winterhart]

@mcrascal @archiewood

• The loading is fixed I've changed the delay pattern
• On compile error we can now see the error message upon refreshing the page (I've re-introduced the previousStatues)

@archiewood

Not working reliably for me - see gif. Sometimes it does, but sometimes it does not and I'm not clear exactly why. It seems to think the query has not changed

I've reduced the delay in the QueryStatus 🤞🏼 it will improve?

I'm getting unstyled content for about a second before the page loads (this may be unrelated)

It's called a FOUT and it's only in dev mode. You can try this website: https://template-demo-evd-sbx.web.app

[hughess]

Did a bit of testing with the most recent updates. We're getting close!

Query Reactivity

I tried changing a query to check the reactivity - it works, but when I try to make several changes in a row it occasionally stops working. I haven't found any patterns for when it stops working, but it seems to kick back in again after a few more query changes.

Hopefully this gif isn't too blurry, but I was changing the year in the where clause and expected the see the number of records drop from 36 to 35, and then to 11. The query updated to show 35 records successfully, but got stuck at 35 when I expected it to drop to 11. On page refresh, the update went through:

Show/Hide Animation

I noticed that a scrollbar appears for a split second on the bottom right of the query viewer when it's shown/hidden: