Update search.html #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't necessarily have to say this but the way it's currently written suggests you're introducing something new when you're really just finishing the process. I was confused by this and thought the plugin had lost functionality and found others online with the same issue. Alternately it could say "1 more step! Adding the new search engine via the URL bar"
|
Thanks for the pull request. I didn't realize that this message could confusing. And sorry for not responding sooner, I don't check github notifications regularly. I think
as a big text is maybe a bit ugly. Maybe we could do something like:
|
|
No worries, I only just now realized you left a message. Sounds good, I went ahead and changed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't necessarily have to say this but the way it's currently written suggests you're introducing something new when you're really just finishing the process. I was confused by this and thought the plugin had lost functionality and found others online with the same issue.
Alternately it could say "1 more step! Adding the new search engine via the URL bar"