Allow starting in background when tray not available #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use QLocalSocket and QLocalServer instead of lockfile This allows to open window of running instance when user is trying to start new instance.
|
hey @WojtekWidomski , thank you for looking into this. What is the purpose of the change, launch the GUI when the systray is not available? |
|
@gustavo-iniguez-goya I don't want tray icon, but when OpenSnitch is added to startup applications and gnome-shell-extension-appindicator is disabled, OpenSnitch window shows on every login. |
|
Thank you @WojtekWidomski ! I'll rework it a little bit, but it improves what @munix9 solved with the lockfile and at the same time solved the problem of displying the GUI on demand when the systray is not available. Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--backgroundcommand line argument that starts GUI in background even when tray not available and uses QLocalSocket and QLocalServer instead of lockfile (now it is possible to open window without starting new instance, using launcher in programs menu).Please review this code, because I never used Qt.
This will fix issue #940.