npm compatibility #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would of course be fine with me to put the npm overlay stuff into the top-level object, but I didn't want to disturb anything else that might be using this, as it is a very portable project.
|
Pulled and published as |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd really like to get this markdown lib into the nodejs/npm ecosystem, since it's pretty nice and definitely the most full-featured pure-js markdown parser.
TJ has renamed his "markdown" lib to "discount", which makes more sense, since it's really just nodejs bindings to the C discount lib. I'd have used that, but it doesn't compile easily on Solaris, and also doesn't expose as much of the parser goodies.
These two changes make the package easily compatible with express (currently the go-to nodejs web framework). The version is bumped so that it can be clear that it is a break from the 0.1.x "markdown" package, although the exposed nodejs API is backwards compatible with the index.js that I added.
If you would like to move the stuff in the npm overlay in the package.json out to the top-level object, then that would be fine with me, of course, but I didn't want to disturb anything that you might be using it for.
Ash Berlin is now an owner of the "markdown" package name on npm's registry, so you should be able to publish this without any problems.