Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #188

Closed
wants to merge 1 commit into from
Closed

Update README.md #188

wants to merge 1 commit into from

Conversation

samelawrence
Copy link
Contributor

-- Grammar fixes. Being an asshole and getting nitpicky.

-- Grammar fixes. Being an asshole and getting nitpicky.
@evilstreak
Copy link
Owner

Nitpicky grammar fixes are ace, but could you keep the text wrapped to 80 characters? (I'd also be happy with 72. The README isn't very consistent on choosing between those two values)

@samelawrence
Copy link
Contributor Author

@evilstreak I intentionally made all paragraphs single-line since Github (and most text editors) support soft text wrapping, however, I'm a self-taught and very junior developer, so I'm not sure of protocol on this. Is there a reason we would manually restrict character count per line? It seems like this is a use case where more modern editors are doing the work for us, and it's a legacy concern to limit to 76 or 80 characters per line.

I'm interested to hear your thoughts on this, but I am more than happy to modify my PR to match your style preferences.

@samelawrence
Copy link
Contributor Author

I'm closing this one, and have submitted a new PR with better fixes.

@evilstreak
Copy link
Owner

Re: your line length question — I spend most of my time in terminals and Vim, so find wrapped files significantly easier to work with.

@samelawrence
Copy link
Contributor Author

@evilstreak Ah, ok, that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants