Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

No need to support raw eth tx in default tx encoder/decoder #711

Closed
yihuang opened this issue Nov 1, 2021 · 1 comment · Fixed by #714
Closed

No need to support raw eth tx in default tx encoder/decoder #711

yihuang opened this issue Nov 1, 2021 · 1 comment · Fixed by #714

Comments

@yihuang
Copy link
Contributor

yihuang commented Nov 1, 2021

Proposal: don't support raw eth tx in default tx decoder

Current behavior: currently it tries to decode ethtypes.Transaction first then fallback to the cosmos-sdk one.

Desired behavior: don't try to decode ethtypes.Transaction at all.

Use case:

  • Since the RPC API always wraps the eth tx in a cosmos standard tx, no need to decode it in the tx decoder.
  • There could be issues if some cosmos tx encoding is identical with an eth tx, it's rare though.
@fedekunze
Copy link
Contributor

yeah, agree. There it shouldn't be the case. Let's remove it and use the default decoder from the SDK

yihuang added a commit to yihuang/ethermint that referenced this issue Nov 2, 2021
@yihuang
remove MsgEthereumTx support in TxConfig
3e919bf 
Closes: evmos#711
@yihuang yihuang mentioned this issue Nov 2, 2021
Merged
11 tasks
fedekunze pushed a commit that referenced this issue Nov 2, 2021
@yihuang
encoding: rm MsgEthereumTx custom support in TxConfig (#714)
d1446fc 
* remove MsgEthereumTx support in TxConfig

Closes: #711

* changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove MsgEthereumTx support in TxConfig yihuang/ethermint
2 participants
@yihuang @fedekunze