Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

remove MsgEthereumTx support in TxConfig #714

Merged
merged 2 commits into from Nov 2, 2021
Merged

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Nov 2, 2021

Closes: #711

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #714 (4407a2b) into main (bc1d81c) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   57.11%   57.01%   -0.11%     
==========================================
  Files          63       63              
  Lines        5557     5532      -25     
==========================================
- Hits         3174     3154      -20     
+ Misses       2201     2197       -4     
+ Partials      182      181       -1     
Impacted Files Coverage Δ
encoding/config.go 100.00% <100.00%> (+11.90%) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack pending changelog entry

@yihuang
Copy link
Contributor Author

yihuang commented Nov 2, 2021

Ack pending changelog entry

changelog added.

@fedekunze fedekunze merged commit d1446fc into evmos:main Nov 2, 2021
@yihuang yihuang deleted the tx-decoder branch November 2, 2021 10:27
@ghost ghost mentioned this pull request Nov 8, 2021
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No need to support raw eth tx in default tx encoder/decoder
2 participants