-
Notifications
You must be signed in to change notification settings - Fork 557
Make NewAnteHandler returns error if input is invalid #1173
Conversation
make NewAnteHandler safer too use, and closer to cosmos-sdk api. extracted from evmos#1168
Codecov Report
@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
- Coverage 62.30% 62.27% -0.04%
==========================================
Files 91 91
Lines 7367 7369 +2
==========================================
- Hits 4590 4589 -1
- Misses 2551 2553 +2
- Partials 226 227 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was wrong with the prev implementation?
@@ -28,7 +28,7 @@ type HandlerOptions struct { | |||
MaxTxGasWanted uint64 | |||
} | |||
|
|||
func (options HandlerOptions) Validate() error { | |||
func (options HandlerOptions) validate() error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this private now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one less thing to maintain? the user should use NewAnteHandler
directly.
Because previously |
make NewAnteHandler safer too use, and closer to cosmos-sdk api. extracted from evmos#1168
make NewAnteHandler safer too use, and closer to cosmos-sdk api. extracted from #1168
make NewAnteHandler safer too use, and closer to cosmos-sdk api. extracted from evmos#1168
make NewAnteHandler safer too use, and closer to cosmos-sdk api. extracted from evmos#1168 (cherry picked from commit 52febec)
Description
make NewAnteHandler safer too use, and closer to cosmos-sdk api.
extracted from #1168
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)