This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Make NewAnteHandler returns error if input is invalid #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make NewAnteHandler safer too use, and closer to cosmos-sdk api. extracted from evmos#1168
yihuang
requested review from
fedekunze,
khoslaventures and
jolube
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
- Coverage 62.30% 62.27% -0.04%
==========================================
Files 91 91
Lines 7367 7369 +2
==========================================
- Hits 4590 4589 -1
- Misses 2551 2553 +2
- Partials 226 227 +1
|
yihuang
changed the title
yihuang
changed the title
fedekunze
reviewed
Jul 18, 2022
| @@ -28,7 +28,7 @@ type HandlerOptions struct { | |||
| MaxTxGasWanted uint64 | |||
| } | |||
|
|
|||
| func (options HandlerOptions) Validate() error { | |||
| func (options HandlerOptions) validate() error { | |||
There was a problem hiding this comment.
why is this private now?
There was a problem hiding this comment.
one less thing to maintain? the user should use NewAnteHandler directly.
Because previously |
fedekunze
approved these changes
Jul 19, 2022
hoanguyenkh
pushed a commit
to AstraProtocol/ethermint
that referenced
this pull request
Jul 27, 2022
make NewAnteHandler safer too use, and closer to cosmos-sdk api. extracted from evmos#1168
facs95
pushed a commit
that referenced
this pull request
Aug 12, 2022
make NewAnteHandler safer too use, and closer to cosmos-sdk api. extracted from #1168
hoanguyenkh
pushed a commit
to AstraProtocol/ethermint
that referenced
this pull request
Aug 17, 2022
make NewAnteHandler safer too use, and closer to cosmos-sdk api. extracted from evmos#1168
devon-chain
pushed a commit
to FunctionX/ethermint
that referenced
this pull request
Nov 17, 2022
make NewAnteHandler safer too use, and closer to cosmos-sdk api. extracted from evmos#1168 (cherry picked from commit 52febec)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make NewAnteHandler safer too use, and closer to cosmos-sdk api.
extracted from #1168
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)