This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
[ENG-626] Rpc types integration tests #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facs95
requested review from
fedekunze,
khoslaventures and
jolube
as code owners
fedekunze
approved these changes
Aug 1, 2022
yihuang
reviewed
Aug 1, 2022
facs95
approved these changes
Aug 3, 2022
|
You need to merge with the recent main branch to get the integration test running, currently, it's not running in github actions. |
Codecov Report
@@ Coverage Diff @@
## main #1207 +/- ##
=======================================
Coverage 57.20% 57.20%
=======================================
Files 94 94
Lines 8424 8424
=======================================
Hits 4819 4819
Misses 3358 3358
Partials 247 247
|
facs95
reviewed
Aug 4, 2022
facs95
pushed a commit
that referenced
this pull request
Aug 12, 2022
hoanguyenkh
pushed a commit
to AstraProtocol/ethermint
that referenced
this pull request
Aug 17, 2022
* types tests * cleanup * cleanup * fix differences in the rpc calls with geth * cleanup * fix linter. getProof future queries now behave as geth * fix spelling Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
devon-chain
pushed a commit
to FunctionX/ethermint
that referenced
this pull request
Nov 17, 2022
* types tests * cleanup * cleanup * fix differences in the rpc calls with geth * cleanup * fix linter. getProof future queries now behave as geth * fix spelling Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit e8fd0e3)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
Check rpc return types against geth, and expected results
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)