Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

1512 set RANDOM opcode #1519

Closed
wants to merge 2 commits into from
Closed

1512 set RANDOM opcode #1519

wants to merge 2 commits into from

Conversation

danburck
Copy link
Contributor

@danburck danburck commented Nov 30, 2022 •
edited
Loading

Closes: #1512

@danburck danburck marked this pull request as ready for review November 30, 2022 19:33
@danburck danburck requested a review from a team as a code owner November 30, 2022 19:33
@danburck danburck requested review from 0a1c and GAtom22 and removed request for a team November 30, 2022 19:33
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #1519 (809618b) into main (ecd7639) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1519   +/-   ##
=======================================
  Coverage   68.70%   68.71%           
=======================================
  Files         103      103           
  Lines        9938     9941    +3     
=======================================
+ Hits         6828     6831    +3     
  Misses       2730     2730           
  Partials      380      380
Impacted Files Coverage Δ
x/evm/keeper/state_transition.go 82.10% <100.00%> (+0.15%) ⬆️

@0a1c 0a1c mentioned this pull request Nov 30, 2022
Merged
11 tasks
0a1c
0a1c suggested changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@0a1c 0a1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value of RANDOM is the hard-coded OpCode (0x44), not an actual random value.

@fedekunze
Copy link
Contributor

closing in favor of #1520

@fedekunze fedekunze closed this Dec 1, 2022
@fedekunze fedekunze deleted the 1512-set-RANDOM-opcode branch December 1, 2022 07:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@0a1c 0a1c 0a1c requested changes

@GAtom22 GAtom22 Awaiting requested review from GAtom22 GAtom22 is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing EIP-4399 RANDOM opcode info
3 participants
@danburck @fedekunze @0a1c