Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Add support for MaxOpenConnections #1229

Merged
merged 8 commits into from
Aug 10, 2022
Merged

Add support for MaxOpenConnections #1229

merged 8 commits into from
Aug 10, 2022

Conversation

facs95
Copy link
Contributor

@facs95 facs95 commented Aug 9, 2022

Closes: #XXX

Description

Added support for setting max-open-connections on RPC server listener. Added a new flag json-rpc.max-open-connections.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1229 (fd4ac3b) into main (b3242ea) will decrease coverage by 0.00%.
The diff coverage is 6.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1229      +/-   ##
==========================================
- Coverage   51.92%   51.92%   -0.01%     
==========================================
  Files         102      102              
  Lines        9282     9284       +2     
==========================================
+ Hits         4820     4821       +1     
- Misses       4214     4215       +1     
  Partials      248      248              
Impacted Files Coverage Δ
server/config/config.go 22.15% <6.66%> (+0.33%) ⬆️

CHANGELOG.md Outdated Show resolved Hide resolved
server/config/config.go Outdated Show resolved Hide resolved
server/util.go Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) August 10, 2022 11:45
@fedekunze fedekunze merged commit 42abb25 into main Aug 10, 2022
@fedekunze fedekunze deleted the max-connections branch August 10, 2022 12:26
facs95 added a commit that referenced this pull request Aug 12, 2022
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Aug 17, 2022
devon-chain pushed a commit to FunctionX/ethermint that referenced this pull request Nov 17, 2022
@danburck danburck mentioned this pull request Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants