Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

eth_sendTransaction returns internal trace on missing param #1284

Merged
merged 13 commits into from
Aug 25, 2022

Conversation

adisaran64
Copy link
Contributor

Closes: #1275

Description

changes the eth_sendTransaction request to provide a properly formatted error (instead of an internal stack trace) when missing input params (the from field)


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@github-actions github-actions bot added the Type: Tests issues and PR related to tests label Aug 19, 2022
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #1284 (f611e7c) into main (f9c74e2) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1284   +/-   ##
=======================================
  Coverage   52.13%   52.13%           
=======================================
  Files         105      105           
  Lines        9547     9547           
=======================================
  Hits         4977     4977           
  Misses       4302     4302           
  Partials      268      268           
Impacted Files Coverage Δ
rpc/backend/sign_tx.go 0.00% <0.00%> (ø)

@adisaran64 adisaran64 marked this pull request as ready for review August 20, 2022 00:52
Copy link
Contributor

@facs95 facs95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adisaran64 ! This looks great. Please just remove those two lines and this should be ready to merge 👌

tests/rpc/rpc_test.go Outdated Show resolved Hide resolved
@adisaran64 adisaran64 requested a review from facs95 August 22, 2022 18:35
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Can you add a bug-fix changelog entry?

@facs95 facs95 enabled auto-merge (squash) August 24, 2022 18:11
@facs95 facs95 merged commit 1ea0cb3 into main Aug 25, 2022
@facs95 facs95 deleted the adisaran64/internal-trace branch August 25, 2022 11:22
@danburck danburck mentioned this pull request Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Tests issues and PR related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_sendTransaction returns internal trace on missing param
3 participants