Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Add opcode test to suites #273

Merged
merged 5 commits into from
Jul 20, 2021
Merged

Conversation

yijiasu-crypto
Copy link
Contributor

Closes: #XXX

Description

Add some opcode test from the original go-ethereum protocol. Original test files can be found here: https://github.com/ethereum/go-ethereum/tree/master/tests/solidity

The opcode test will ask EVM to run all opcode defined by Ethereum Yellow Paper to make sure the EVM performs correctly.

Run yarn test --network ethermint opcode to perform this test.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good but I'm afraid the contracts on geth were updated for the last time 2 years ago so there might be a few opcodes missing. Can you check that and add them too if possible?

Also, if you could add a README.md on the opcode/ directory to run the tests that would be amazing

@yijiasu-crypto
Copy link
Contributor Author

this looks good but I'm afraid the contracts on geth were updated for the last time 2 years ago so there might be a few opcodes missing. Can you check that and add them too if possible?

Also, if you could add a README.md on the opcode/ directory to run the tests that would be amazing

Sure. Will do

@fedekunze
Copy link
Contributor

@yijiasu-crypto are you going to add the opcodes? or should we add them on a separate PR?

@yijiasu-crypto
Copy link
Contributor Author

Yes I think we could just merge this.

I will issue a separate PR to add more opcode tests.

@fedekunze fedekunze enabled auto-merge (squash) July 20, 2021 12:54
@fedekunze
Copy link
Contributor

I will issue a separate PR to add more opcode tests.

@yijiasu-crypto can you create an issue to keep track of progress?

@fedekunze fedekunze merged commit bb6622b into evmos:main Jul 20, 2021
mmsqe added a commit to mmsqe/ethermint that referenced this pull request Jun 14, 2023
)

* fix parse for websocket connID

* update doc
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants