RPC: debug_traceTransaction endpoint
#506
Conversation
|
Visit https://dashboard.github.orijtech.com?back=0&pr=506&remote=true&repo=crypto-facs%2Fethermint to see benchmark details. |
Codecov Report
@@ Coverage Diff @@
## main #506 +/- ##
==========================================
- Coverage 50.45% 50.11% -0.34%
==========================================
Files 59 60 +1
Lines 5522 5705 +183
==========================================
+ Hits 2786 2859 +73
- Misses 2614 2718 +104
- Partials 122 128 +6
|
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
There was a problem hiding this comment.
ACK! Minor comments. Can you also add the docs for the JSON-RPC endpoint? Thanks @crypto-facs! 💯
|
|
||
| //check if block number is 0 | ||
| if transaction.Height == 0 { | ||
| return nil, errors.New("genesis is not traceable") |
There was a problem hiding this comment.
note: you can use a.clientCtx.Client.Genesis(a.ctx) to get the genesis
| if trace.Stack != nil { | ||
| stack := make([]string, len(trace.Stack)) | ||
| for i, stackValue := range trace.Stack { | ||
| stack[i] = fmt.Sprintf("%x", stackValue) |
There was a problem hiding this comment.
use hex.EncodeToString, it's faster
There was a problem hiding this comment.
@crypto-facs can you create an issue for this? Ideally, we should also add a test and a benchmark
| if trace.Stack != nil { | ||
| stack := make([]string, len(trace.Stack)) | ||
| for i, stackValue := range trace.Stack { | ||
| stack[i] = fmt.Sprintf("%x", stackValue) |
There was a problem hiding this comment.
@crypto-facs can you create an issue for this? Ideally, we should also add a test and a benchmark
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
|
@crypto-facs can you also add a Changelog entry under |
Closes: #71
Description
First PR for
debug_traceTansactionendpoint implementation. Second PR will add custom config param for custom javascript tracing that GETH supports. The goal is not to make this PR huge.NOTE: The trace result is return as a slice of bytes due to uncertainty in the type of the response. By passing a custom param the response format is completely up to the user.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)