imp(outposts): common function to read ABI (#1973)

* use common function to read abi in precompiles

* fix copypasta docstring

* update CHANGELOG

CHANGELOG.md

@@ -82,6 +82,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 - (distribution) [#1949](https://github.com/evmos/evmos/pull/1949) Add `ClaimRewards` custom transaction.
 - (distribution) [#1954](https://github.com/evmos/evmos/pull/1954) Add `ClaimRewards` unit and event tests.
 - (osmosis-outpost) [#1944](https://github.com/evmos/evmos/pull/1921) Add more validation to Osmosis outpost.
+- (precompiles) [[#1973](https://github.com/evmos/evmos/pull/1973) Use `LoadABI` from precompiles common package in outposts.
 
 ### Bug Fixes
 

precompiles/common/abi.go

@@ -131,6 +131,7 @@ func PackNum(value reflect.Value) []byte {
 	}
 }
 
+// LoadABI read the ABI file described by the path and parse it as JSON.
 func LoadABI(fs embed.FS, path string) (abi.ABI, error) {
 	abiBz, err := fs.ReadFile(path)
 	if err != nil {

precompiles/outposts/osmosis/osmosis.go

@@ -4,7 +4,6 @@
 package osmosis
 
 import (
-	"bytes"
 	"embed"
 	"fmt"
 
@@ -63,19 +62,14 @@ func NewPrecompile(
 	transferKeeper transferkeeper.Keeper,
 	erc20Keeper erc20keeper.Keeper,
 ) (*Precompile, error) {
-	abiBz, err := f.ReadFile("abi.json")
-	if err != nil {
-		return nil, err
-	}
-
-	newAbi, err := abi.JSON(bytes.NewReader(abiBz))
+	abi, err := LoadABI()
 	if err != nil {
 		return nil, err
 	}
 
 	return &Precompile{
 		Precompile: cmn.Precompile{
-			ABI:                  newAbi,
+			ABI:                  abi,
 			KvGasConfig:          storetypes.KVGasConfig(),
 			TransientKVGasConfig: storetypes.TransientGasConfig(),
 			ApprovalExpiration:   cmn.DefaultExpirationDuration, // should be configurable in the future.
@@ -90,6 +84,12 @@ func NewPrecompile(
 	}, nil
 }
 
+// LoadABI loads the Osmosis outpost ABI from the embedded abi.json file
+// for the Osmosis outpost precompile.
+func LoadABI() (abi.ABI, error) {
+	return cmn.LoadABI(f, "abi.json")
+}
+
 // Address defines the address of the Osmosis outpost precompile contract.
 func (Precompile) Address() common.Address {
 	return common.HexToAddress(OsmosisOutpostAddress)

precompiles/outposts/stride/stride.go

@@ -4,7 +4,6 @@
 package stride
 
 import (
-	"bytes"
 	"embed"
 	"fmt"
 
@@ -48,19 +47,14 @@ func NewPrecompile(
 	authzKeeper authzkeeper.Keeper,
 	stakingKeeper stakingkeeper.Keeper,
 ) (*Precompile, error) {
-	abiBz, err := f.ReadFile("abi.json")
-	if err != nil {
-		return nil, err
-	}
-
-	newAbi, err := abi.JSON(bytes.NewReader(abiBz))
+	abi, err := LoadABI()
 	if err != nil {
 		return nil, err
 	}
 
 	return &Precompile{
 		Precompile: cmn.Precompile{
-			ABI:                  newAbi,
+			ABI:                  abi,
 			AuthzKeeper:          authzKeeper,
 			KvGasConfig:          storetypes.KVGasConfig(),
 			TransientKVGasConfig: storetypes.TransientGasConfig(),
@@ -75,6 +69,12 @@ func NewPrecompile(
 	}, nil
 }
 
+// LoadABI loads the Stride outpost ABI from the embedded abi.json file
+// for the Stride outpost precompile.
+func LoadABI() (abi.ABI, error) {
+	return cmn.LoadABI(f, "abi.json")
+}
+
 // Address defines the address of the Stride Outpost precompile contract.
 func (Precompile) Address() common.Address {
 	return common.HexToAddress("0x0000000000000000000000000000000000000900")