imp(outposts): common function to read ABI #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xstepit
requested review from
MalteHerrmann and
GAtom22
and removed request for
a team
fedekunze
approved these changes
Oct 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #1973 +/- ##
==========================================
+ Coverage 69.90% 69.91% +0.01%
==========================================
Files 327 327
Lines 24297 24293 -4
==========================================
+ Hits 16984 16985 +1
+ Misses 6442 6438 -4
+ Partials 871 870 -1
|
facs95
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aim to remove the ABI logic from inside the outpost implementations to use the specific function inside precompiles common package.
Closes #XXX