Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(erc20): Deprecate x/params usage in x/erc20 #1100

Merged
merged 56 commits into from Dec 16, 2022

Conversation

Vvaradinov
Copy link
Contributor

@Vvaradinov Vvaradinov commented Nov 22, 2022

Description

Deprecate the usage of the now legacy Cosmos SDK params module within x/erc20.

For more details check the initial PR on Ethermint here

Closes: ENG-1059


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@linear
Copy link

linear bot commented Nov 22, 2022

@github-actions github-actions bot added the proto label Nov 22, 2022
x/erc20/types/msg.go Fixed Show fixed Hide fixed
@Vvaradinov Vvaradinov changed the title chore(erc20): Refactor module params to Cosmos SDK 0.47.0 release chore(erc20): Deprecate x/params usage in x/erc20 Nov 25, 2022
@evmos evmos deleted a comment from lgtm-com bot Nov 30, 2022
@fedekunze
Copy link
Contributor

@Vvaradinov can you check the failing tests?

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #1100 (6b426a8) into main (6d17942) will decrease coverage by 0.11%.
The diff coverage is 70.32%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1100      +/-   ##
==========================================
- Coverage   76.82%   76.71%   -0.12%     
==========================================
  Files         149      149              
  Lines        8061     8116      +55     
==========================================
+ Hits         6193     6226      +33     
- Misses       1682     1698      +16     
- Partials      186      192       +6     
Impacted Files Coverage Δ
x/erc20/handler.go 5.88% <0.00%> (-1.27%) ⬇️
x/erc20/genesis.go 72.22% <33.33%> (-11.12%) ⬇️
x/erc20/types/msg.go 88.73% <38.46%> (-11.27%) ⬇️
x/erc20/keeper/keeper.go 87.50% <50.00%> (-12.50%) ⬇️
x/erc20/types/codec.go 31.81% <50.00%> (+1.81%) ⬆️
x/erc20/types/params.go 85.71% <50.00%> (-14.29%) ⬇️
x/erc20/keeper/msg_server.go 97.56% <66.66%> (-0.78%) ⬇️
x/erc20/migrations/v3/migration.go 80.00% <80.00%> (ø)
x/erc20/keeper/params.go 90.90% <90.32%> (-9.10%) ⬇️
app/app.go 81.81% <100.00%> (ø)
... and 4 more

@Vvaradinov Vvaradinov merged commit 6ee0fce into main Dec 16, 2022
@Vvaradinov Vvaradinov deleted the Vvaradinov/erc20-params-refactor branch December 16, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants