New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(erc20): Deprecate x/params usage in x/erc20 #1100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vvaradinov
changed the title
chore(erc20): Refactor module params to Cosmos SDK 0.47.0 release
chore(erc20): Deprecate x/params usage in x/erc20
Nov 25, 2022
# Conflicts: # x/erc20/keeper/ibc_callbacks_integration_test.go
…/evmos/evmos into Vvaradinov/erc20-params-refactor
…/evmos/evmos into Vvaradinov/erc20-params-refactor
fedekunze
approved these changes
Dec 16, 2022
@Vvaradinov can you check the failing tests? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1100 +/- ##
==========================================
- Coverage 76.82% 76.71% -0.12%
==========================================
Files 149 149
Lines 8061 8116 +55
==========================================
+ Hits 6193 6226 +33
- Misses 1682 1698 +16
- Partials 186 192 +6
|
…/evmos/evmos into Vvaradinov/erc20-params-refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecate the usage of the now legacy Cosmos SDK params module within x/erc20.
For more details check the initial PR on Ethermint here
Closes: ENG-1059
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
Code maintenance:
I have...
godoc
and code comments.docs/
) or specification (x/<module>/spec/
)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...