Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmd): Set default mempool to 'v1' and update default snapshot interval to 5000 #1172

Merged
merged 4 commits into from
Dec 19, 2022

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Dec 16, 2022

Description

Closes: ENG-1122

Sets default mempool to "v1" on initialization and snapshot interval to 4,000 blocks


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@linear
Copy link

linear bot commented Dec 16, 2022

ENG-1122 Investigate Snapshot problems on mainnet

We have a lot of broken snapshots in mainnet. The root cause is the default snapshot interval which set to 1500 blocks. In mainnet snapshot creation takes ~3000 blocks. We should set the snapshot interval to 5000 blocks by default.

@fedekunze fedekunze marked this pull request as ready for review December 16, 2022 12:51
@fedekunze fedekunze requested a review from a team as a code owner December 16, 2022 12:51
@fedekunze fedekunze requested review from hanchon, adisaran64, facs95, litvinsky, Vvaradinov and GAtom22 and removed request for a team December 16, 2022 12:51
@fedekunze fedekunze changed the title chore(cmd): Set default mempool to 'v1' chore(cmd): Set default mempool to 'v1' and update default snapshot interval to 5000 Dec 16, 2022
@fedekunze fedekunze enabled auto-merge (squash) December 19, 2022 13:34
@fedekunze fedekunze merged commit 4bf2846 into main Dec 19, 2022
@fedekunze fedekunze deleted the fedekunze/default-cfg branch December 19, 2022 14:41
facs95 pushed a commit that referenced this pull request Dec 21, 2022
…nterval to `5000` (#1172)

* chore(cmd): Set default mempool to 'v1'

* changelog

* update interval
fedekunze added a commit that referenced this pull request Dec 21, 2022
* debug(app): add flag for remote debugging compile (#1160)

* build(deps): bump github.com/onsi/ginkgo/v2 from 2.6.0 to 2.6.1 (#1168)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/onsi/ginkgo/releases)
- [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md)
- [Commits](onsi/ginkgo@v2.6.0...v2.6.1)

---
updated-dependencies:
- dependency-name: github.com/onsi/ginkgo/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump github.com/onsi/gomega from 1.24.1 to 1.24.2 (#1167)

Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.24.1 to 1.24.2.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](onsi/gomega@v1.24.1...v1.24.2)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(cmd): Set default mempool to 'v1' and update default snapshot interval to `5000` (#1172)

* chore(cmd): Set default mempool to 'v1'

* changelog

* update interval

* build(deps): bump github.com/cosmos/ibc-go/v5 from 5.1.0 to 5.2.0 (#1176)

Bumps [github.com/cosmos/ibc-go/v5](https://github.com/cosmos/ibc-go) from 5.1.0 to 5.2.0.
- [Release notes](https://github.com/cosmos/ibc-go/releases)
- [Changelog](https://github.com/cosmos/ibc-go/blob/v5.2.0/CHANGELOG.md)
- [Commits](cosmos/ibc-go@v5.1.0...v5.2.0)

---
updated-dependencies:
- dependency-name: github.com/cosmos/ibc-go/v5
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* update receiving module accounts

* update changelog

* fix linter and changelog

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants