-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: lint tests #1194
chore: lint tests #1194
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1194 +/- ##
=======================================
Coverage 76.33% 76.33%
=======================================
Files 149 149
Lines 8283 8283
=======================================
Hits 6323 6323
Misses 1768 1768
Partials 192 192
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @faddat !! Left a few comments
Hey, absolutely! |
Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com>
thanks for the review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK. Thanks for doing this @faddat
Description
This PR lints the tests for evmos. The most common/productive finding from linting the tests to ibc-go, Gaia, and the cosmos-sdk has been that we can improve test quality and formatting by changing to
tests:true
in .golangci.yml. The most common improvement is checking for errors more frequently.All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
Code maintenance:
I have...
godoc
and code comments.docs/
) or specification (x/<module>/spec/
)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...