Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lint tests #1194

Merged
merged 25 commits into from
Jan 14, 2023
Merged

chore: lint tests #1194

merged 25 commits into from
Jan 14, 2023

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 26, 2022

Description

This PR lints the tests for evmos. The most common/productive finding from linting the tests to ibc-go, Gaia, and the cosmos-sdk has been that we can improve test quality and formatting by changing to tests:true in .golangci.yml. The most common improvement is checking for errors more frequently.


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@faddat faddat marked this pull request as draft December 26, 2022 17:03
@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #1194 (210b934) into main (4251d93) will not change coverage.
The diff coverage is 50.00%.

❗ Current head 210b934 differs from pull request most recent head 8a3b9a6. Consider uploading reports for the commit 8a3b9a6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1194   +/-   ##
=======================================
  Coverage   76.33%   76.33%           
=======================================
  Files         149      149           
  Lines        8283     8283           
=======================================
  Hits         6323     6323           
  Misses       1768     1768           
  Partials      192      192           
Impacted Files Coverage Δ
app/ante/ante.go 0.00% <0.00%> (ø)
app/ante/handler_options.go 0.00% <0.00%> (ø)
app/export.go 12.50% <0.00%> (ø)
x/erc20/client/cli/tx.go 0.00% <ø> (ø)
x/erc20/keeper/evm_hooks.go 88.88% <ø> (ø)
x/revenue/keeper/grpc_query.go 88.18% <ø> (ø)
x/claims/keeper/ibc_callbacks.go 97.76% <100.00%> (ø)
x/erc20/types/msg.go 88.73% <100.00%> (ø)

@faddat faddat marked this pull request as ready for review December 26, 2022 18:59
Copy link
Contributor

@GAtom22 GAtom22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @faddat !! Left a few comments

x/claims/keeper/ibc_callbacks_test.go Outdated Show resolved Hide resolved
x/erc20/keeper/evm_hooks_test.go Outdated Show resolved Hide resolved
@adisaran64
Copy link
Contributor

@faddat Looks good, but can you address the comments left by @GAtom22 ? Otherwise it might be wise to move this PR to draft for the time being.

@faddat
Copy link
Contributor Author

faddat commented Jan 14, 2023

Hey, absolutely!

faddat and others added 3 commits January 14, 2023 15:25
Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com>
@faddat
Copy link
Contributor Author

faddat commented Jan 14, 2023

thanks for the review :)

Copy link
Contributor

@Vvaradinov Vvaradinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Thanks for doing this @faddat

@fedekunze fedekunze enabled auto-merge (squash) January 14, 2023 17:52
@fedekunze fedekunze merged commit 1d45142 into evmos:main Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants