fix: edit protocgen script and generate common types #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vvaradinov
requested review from
MalteHerrmann and
GAtom22
and removed request for
a team
MalteHerrmann
approved these changes
Feb 1, 2023
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1311 +/- ##
==========================================
- Coverage 72.42% 72.40% -0.02%
==========================================
Files 177 178 +1
Lines 10351 10449 +98
==========================================
+ Hits 7497 7566 +69
- Misses 2623 2645 +22
- Partials 231 238 +7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old
protocgen.shscript was only targeting thex/modules folder and wasn't generating the common types that are present on Ethermint. This PR modifies the script and generates the common types.Closes #XXX