fix(ante): handle zero fee case on evm transactions #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GAtom22
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1753 +/- ##
=======================================
Coverage 70.32% 70.33%
=======================================
Files 297 297
Lines 22287 22293 +6
=======================================
+ Hits 15673 15679 +6
Misses 5847 5847
Partials 767 767
|
GAtom22
requested review from
MalteHerrmann,
0xstepit,
Vvaradinov and
facs95
and removed request for
a team
ENG-2046 Fix bug for Zero fee EVM tx
ContextWhen the genesis parameter feemarket sets no_base_fee=true and min_gas_price=0, the user send a evm transaction with a gasPrice of 0 fails. ExpectedTx should be successful There's a PR addressing this issue already. Tasks:
More details of the issue on this PR |
MalteHerrmann
approved these changes
Sep 14, 2023
|
https://github.com/Mergifyio backport release/v15.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
* fix: handle zero fee case on eth ante * refactor style * add changelog entry * add zero fees unit test case * refactor helper functions * add zero fees integration tests * fix lint issues (cherry picked from commit e041fdf) # Conflicts: # CHANGELOG.md
GAtom22
added a commit
that referenced
this pull request
Oct 16, 2023
…1889) * fix(ante): handle zero fee case on evm transactions (#1753) * fix: handle zero fee case on eth ante * refactor style * add changelog entry * add zero fees unit test case * refactor helper functions * add zero fees integration tests * fix lint issues (cherry picked from commit e041fdf) # Conflicts: # CHANGELOG.md * fix conflicts --------- Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: tom <tomasguerraalda@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change addresses the case reported by @luchenqun of having zero fees for evm transactions
(more details on this PR)
Nit: Before merging these changes, would be great to add some e2e tests to cover this case once the nix testing setup is merged
Closes ENG-2046