imp(tests): improvements to local node script #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalteHerrmann
requested review from
Vvaradinov and
facs95
and removed request for
a team
ENG-2034 Add flags to local node script
ContextThe ExpectedFor copy-pasteable instructions it would be great to be able to pass flags like |
Vvaradinov
approved these changes
Sep 27, 2023
GAtom22
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
tACK! Great work @MalteHerrmann!!
Left one small fix to address
|
@Mergifyio backport release/v14.2.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
* use preconfigured keys * add flags to local node script * address linter * Update local_node.sh --------- Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> (cherry picked from commit cffda8f)
MalteHerrmann
added a commit
that referenced
this pull request
Oct 11, 2023
imp(tests): improvements to local node script (#1805) * use preconfigured keys * add flags to local node script * address linter * Update local_node.sh --------- Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> (cherry picked from commit cffda8f) Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following improvements to the
local_node.shscript:-y: overwrite existing chain data and reset everything-n: do not overwrite existing chain data, continue from last block--no-install: skip installation of the binary (useful if correct version is already installed)Closes ENG-2034