Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epochs Module #183

Merged
merged 9 commits into from
Dec 28, 2021
Merged

Epochs Module #183

merged 9 commits into from
Dec 28, 2021

Conversation

ramacarlucho
Copy link
Contributor

Closes: #XXX

Description

Add osmosis epochs module.

WIP: currently cli_test.go is failing.
The Genesis state is not beeing correctly initialized in the tests, so the client cant find any of the created epochs.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #183 (fcd6062) into main (4fff189) will decrease coverage by 0.25%.
The diff coverage is 71.01%.

❗ Current head fcd6062 differs from pull request most recent head 4d5db04. Consider uploading reports for the commit 4d5db04 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   72.61%   72.35%   -0.26%     
==========================================
  Files          24       33       +9     
  Lines        1727     2040     +313     
==========================================
+ Hits         1254     1476     +222     
- Misses        421      501      +80     
- Partials       52       63      +11     
Impacted Files Coverage Δ
x/epochs/handler.go 20.00% <20.00%> (ø)
x/epochs/keeper/grpc_query.go 38.88% <38.88%> (ø)
x/epochs/module.go 51.61% <51.61%> (ø)
x/epochs/client/cli/query.go 63.15% <63.15%> (ø)
x/epochs/keeper/keeper.go 84.61% <84.61%> (ø)
x/epochs/keeper/epoch.go 87.50% <87.50%> (ø)
app/app.go 80.66% <100.00%> (+0.52%) ⬆️
x/epochs/genesis.go 100.00% <100.00%> (ø)
x/epochs/keeper/abci.go 100.00% <100.00%> (ø)
x/epochs/keeper/hooks.go 100.00% <100.00%> (ø)

@lgtm-com
Copy link

lgtm-com bot commented Dec 23, 2021

This pull request introduces 1 alert when merging 473faa8 into 4fff189 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

proto/evmos/epochs/genesis.proto Outdated Show resolved Hide resolved
proto/evmos/epochs/query.proto Outdated Show resolved Hide resolved
proto/evmos/epochs/query.proto Outdated Show resolved Hide resolved
x/epochs/abci.go Outdated Show resolved Hide resolved
x/epochs/abci.go Outdated Show resolved Hide resolved
x/epochs/types/errors.go Outdated Show resolved Hide resolved
x/epochs/types/genesis.go Outdated Show resolved Hide resolved
x/epochs/types/genesis.go Outdated Show resolved Hide resolved
x/epochs/types/identifier.go Show resolved Hide resolved
x/epochs/types/keys.go Outdated Show resolved Hide resolved
@fedekunze fedekunze mentioned this pull request Dec 23, 2021
11 tasks
proto/evmos/epochs/v1/genesis.proto Outdated Show resolved Hide resolved
proto/evmos/epochs/v1/genesis.proto Outdated Show resolved Hide resolved
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fedekunze fedekunze enabled auto-merge (squash) December 28, 2021 17:17
@fedekunze fedekunze merged commit d8cd81f into main Dec 28, 2021
@fedekunze fedekunze deleted the rama/epochs branch December 28, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants