fix(ics20): Refactor ICS20Authorization to use Allocations #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vvaradinov
requested review from
MalteHerrmann and
0xstepit
and removed request for
a team
0xstepit
reviewed
Oct 12, 2023
Co-authored-by: stepit <48993133+0xstepit@users.noreply.github.com>
0xstepit
approved these changes
Oct 12, 2023
Co-authored-by: stepit <48993133+0xstepit@users.noreply.github.com>
MalteHerrmann
approved these changes
Oct 12, 2023
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
0xstepit
deleted the
Vvaradinov/refactor-ics20-authorization-and-events
branch
|
https://github.com/Mergifyio backport release/v15.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
* fix: add some of the refactors * add CHANGELOG * Update precompiles/authorization/IICS20Authorization.sol Co-authored-by: stepit <48993133+0xstepit@users.noreply.github.com> * Update precompiles/authorization/IICS20Authorization.sol Co-authored-by: stepit <48993133+0xstepit@users.noreply.github.com> * Update precompiles/common/types.go Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * fix: rename Allocation to ICS20Allocation --------- Co-authored-by: stepit <48993133+0xstepit@users.noreply.github.com> Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> (cherry picked from commit c1c861e)
0xstepit
pushed a commit
that referenced
this pull request
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the first of a series aiming to refactor the ICS20 Extension Approvals to be more aligned with IERC20 Approvals.
Revokespecific Event, now it will just emitApprovewith 0AllocationAllocationto common packageCloses #XXX