imp(evm): enable EIP 3855 during upgrade

[MalteHerrmann]

Description

This PR adds the necessary logic to enable EIP 3855 during the v14.2.0 upgrade.

More context can be found in this Medium article.

---

Closes ENG-2149

[linear]

ENG-2149 Update EVM Params with missing EIPs

Context

There was a user request on the Evmos Builders TG Channel who wanted to deploy a smart contract which used Solidity v0.8.20. This requires the PUSH0 opcode to be available, which is added in EIP 3855.

In the Geth version we are using at this moment (v1.10.26-evmos-rc2) this opcode is not enabled by default (there is no check for the Shanghai fork) and has to be added by populating the ExtraEIPs field in the EVM parameters.

Expected

• Check for missing EIPs other than this described one

• Enable them on

  • testnet
  • mainnet

Update

Two EIPs are enabled with the Shanghai instruction set:

• EIP 3855: PUSH0 instruction
  Introduce a new instruction which pushes the constant value 0 onto the stack.
• EIP 3860: Limit and meter initcode
  Limit the maximum size of initcode to 49152 and apply extra gas cost of 2 for every 32-byte chunk of initcode.
  → This is not supported in Geth v1.10.26 (see here)

[codecov]

Codecov Report

Merging #1851 (143515a) into release/v14.2.x (fc2c9a2) will decrease coverage by 0.04%.
The diff coverage is 70.58%.

@@                 Coverage Diff                 @@
##           release/v14.2.x    #1851      +/-   ##
===================================================
- Coverage            70.50%   70.46%   -0.04%     
===================================================
  Files                  313      314       +1     
  Lines                23312    23343      +31     
===================================================
+ Hits                 16436    16449      +13     
- Misses                6052     6069      +17     
- Partials               824      825       +1     

Files	Coverage Δ
app/app.go	82.77% <100.00%> (+0.01%)	⬆️
x/evm/types/params.go	72.38% <100.00%> (+1.67%)	⬆️
app/upgrades/v14_2/upgrades.go	25.00% <50.00%> (ø)

[MalteHerrmann]

E2E tests have been run locally and pass 🤷

[GAtom22]

Great work @MalteHerrmann!!

Left one comment

Should we add the EIP in the AvailableExtraEIPs as well?

[MalteHerrmann]

Should we add the EIP in the AvailableExtraEIPs as well?

That slice is only used once in migration tests. I will move it directly to the migration tests and remove it from the params types. ✌️ Good catch!

[GAtom22]

LGTM! Great work @MalteHerrmann !!

[GAtom22]

would be great to understand why is breaking the e2e tests, cause this may break them for future PRs

[MalteHerrmann]

would be great to understand why is breaking the e2e tests, cause this may break them for future PRs

I agree, it's kind of hard to debug because there's not much info printed in the logs and they run fine locally 🤔 I was thinking that we should split the workflows for CLI tests and upgrade tests to be able to more easily identify which ones are failing too

[fedekunze]

@MalteHerrmann why is this being pushed to the release branch and not main?

[MalteHerrmann]

@MalteHerrmann why is this being pushed to the release branch and not main?

Because this is only affecting the upgrade handler which doesn't exist on main yet. This is a good point - I will backport the upgrade handler to main and then change the target of this PR to point to main as well.

[MalteHerrmann]

and then change the target of this PR to point to main as well.

@fedekunze actually it will be easier to merge it like this and then backport to main

Addressed all comments

[fedekunze]

Left a minor comment about the dup check approach

[MalteHerrmann]

@Mergifyio backport main

[mergify]

backport main

✅ Backports have been created

• #1859 imp(evm): enable EIP 3855 during upgrade (backport #1851) has been created for branch main