Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp(werc20): WERC-20 Events #1990

Merged
merged 8 commits into from Nov 3, 2023
Merged

imp(werc20): WERC-20 Events #1990

merged 8 commits into from Nov 3, 2023

Conversation

fedekunze
Copy link
Contributor

Description

Closes #XXX

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 3, 2023
View reviewed changes
precompiles/werc20/events.go Dismissed Show dismissed Hide dismissed
@fedekunze fedekunze marked this pull request as ready for review November 3, 2023 10:40
@fedekunze fedekunze requested a review from a team as a code owner November 3, 2023 10:40
@fedekunze fedekunze requested review from facs95 and MalteHerrmann and removed request for a team November 3, 2023 10:40
MalteHerrmann
MalteHerrmann approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@MalteHerrmann MalteHerrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good stuff 👍

precompiles/werc20/events.go Outdated Show resolved Hide resolved
0xstepit
0xstepit approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@0xstepit 0xstepit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nit to maintain coherence in the codebase.

precompiles/werc20/events.go Show resolved Hide resolved
precompiles/werc20/types.go Outdated Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) November 3, 2023 13:54
GAtom22
GAtom22 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@GAtom22 GAtom22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @fedekunze!!

Left a couple of nits

precompiles/werc20/events.go Outdated Show resolved Hide resolved
precompiles/werc20/events.go Outdated Show resolved Hide resolved
fedekunze and others added 2 commits November 3, 2023 15:51
@fedekunze @GAtom22
Apply suggestions from code review
3818140 
Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
@fedekunze
Merge branch 'main' into fedekunze/werc20-events
c60b949
@fedekunze fedekunze merged commit 25ccc47 into main Nov 3, 2023
13 of 23 checks passed
@fedekunze fedekunze deleted the fedekunze/werc20-events branch November 3, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MalteHerrmann MalteHerrmann MalteHerrmann approved these changes

@0xstepit 0xstepit 0xstepit approved these changes

@GAtom22 GAtom22 GAtom22 approved these changes

@facs95 facs95 Awaiting requested review from facs95 facs95 is a code owner automatically assigned from evmos/core-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fedekunze @MalteHerrmann @0xstepit @GAtom22