Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(osmosis-outpost): add receiver address validation #2063

Merged
merged 6 commits into from Nov 21, 2023

Conversation

0xstepit
Copy link
Contributor

Description

This PR includes an additional validation on the receiver address to check that it is an bech32 with "evmos" prefix.


Closes #XXX

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #2063 (3c255df) into main (4a1b3f5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2063      +/-   ##
==========================================
- Coverage   70.16%   70.16%   -0.01%     
==========================================
  Files         340      340              
  Lines       25454    25453       -1     
==========================================
- Hits        17861    17860       -1     
  Misses       6675     6675              
  Partials      918      918              
Files Coverage Δ
precompiles/outposts/osmosis/types.go 91.89% <100.00%> (-0.08%) ⬇️

@0xstepit 0xstepit marked this pull request as ready for review November 21, 2023 08:13
@0xstepit 0xstepit requested a review from a team as a code owner November 21, 2023 08:13
@0xstepit 0xstepit requested review from Vvaradinov and GAtom22 and removed request for a team November 21, 2023 08:13
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment for simplicity

precompiles/outposts/osmosis/types.go Outdated Show resolved Hide resolved
@0xstepit 0xstepit merged commit b0f0098 into main Nov 21, 2023
35 checks passed
@0xstepit 0xstepit deleted the stepit/update-outpost branch November 21, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants